Generalize meta_path json file creation in load.py [#4540] #4590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In function `_copy_script_and_other_resources_in_importable_dir`, using string split when generating `meta_path` throws error in the edge case raised in #4540. Using `os.path.splitext` generalizes json path creation.
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
Author
|
@albertvillanova, Can you please review this PR for Issue #4540 |
Contributor
Author
|
@lhoestq Thank you for merging the PR . Is there a slack channel for contributing to the datasets library. I would love to work on the library and make meaningful contributions. |
Member
|
Hi ! Sure feel free to join our discord ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Summary
In function
_copy_script_and_other_resources_in_importable_dir, using string split when generatingmeta_paththrows error in the edge case raised in #4540.Additions
Changes
os.path.splitextinstead of usingstr.splitto generalize code.Deletions
Issues Addressed :
Fixes #4540